Merge pull request #1627 from saratomaz/update_load_tx_view
update load_tx_view and use it on check_tx_view
update load_tx_view and use it on check_tx_view
assert not return_collateral_utxos, "Return collateral UTxO was unexpectedly created"
return
tx_view_out = tx_view.load_tx_view(cluster_obj=cluster_obj, tx_raw_output=tx_output)
tx_view_out = tx_view.load_tx_view(cluster_obj=cluster_obj, tx_body_file=tx_output.out_file)
# TODO: automatic return collateral is not supported on 1.35.3 and older
if not (
import json
import logging
import re
from pathlib import Path
from typing import Any
from typing import Dict
from typing import List
), "Return collateral address mismatch"
def load_tx_view(
cluster_obj: clusterlib.ClusterLib, tx_raw_output: clusterlib.TxRawOutput
) -> Dict[str, Any]:
def load_tx_view(cluster_obj: clusterlib.ClusterLib, tx_body_file: Path) -> Dict[str, Any]:
# TODO: see https://github.com/input-output-hk/cardano-node/issues/4039
try:
tx_view_raw = cluster_obj.g_transaction.view_tx(tx_body_file=tx_raw_output.out_file)
tx_view_raw = cluster_obj.g_transaction.view_tx(tx_body_file=tx_body_file)
except clusterlib.CLIError as exc:
if "TODO: Babbage" in str(exc):
return {}
"""Check output of the `transaction view` command."""
# pylint: disable=too-many-branches,too-many-locals,too-many-statements
# TODO: see https://github.com/input-output-hk/cardano-node/issues/4039
try:
tx_view_raw = cluster_obj.g_transaction.view_tx(tx_body_file=tx_raw_output.out_file)
except clusterlib.CLIError as exc:
if "TODO: Babbage" in str(exc):
return {}
tx_loaded: Dict[str, Any] = load_raw(tx_view=tx_view_raw)
tx_loaded = load_tx_view(cluster_obj=cluster_obj, tx_body_file=tx_raw_output.out_file)
# check inputs
loaded_txins = set(tx_loaded.get("inputs") or [])
fix CI not running on bors branches
5023: fix CI not running on bors branches r=disassembler a=dermetfan Looks like this was broken in #4930 as `prAndBorsIo` was added but not used. Also removed `nix` from the task name. I do not see what purpose it has and it makes the names unnecessarily long. Also we happen to need the old names in #5018. Co-authored-by: Robin Stumm <[email protected]>
I don't trust it. Compare these two runs: 1. https://github.com/input-output-hk/cardano-haskell-packages/actions/runs/4532746158/jobs/7984714895 2. https://github.com/input-output-hk/cardano-haskell-packages/actions/runs/4516172089/jobs/7954255360 The second is on the parent commit of the first, the commit itself is a no-op, and yet the derivations they build are not the same! Doing the same locally, I get a) a different derivation, but b) the same derivation for both. I conclude that what the CI is doing is questionable, the cache seems like the most likely source of pollution. I suspect whatever is causing this was also responsible for the no-op PR spending a lot of time building tons of stuff.
* Update readme (cli flags, comment dsl, new format) * Document the comment DSL * Document CLI flags * Mention new split rust/wasm output structure * Remove unsupported section (to handle in issues instead as this tends to get very outdated) * respond to comments + add supported.cddl * minor fixes for comment placement in supported.cddl + remove unsupported optional fixed value from example
There's an issue with the `deriving via` clause for OneEraHeader: * `show`ing a `NS Header (CardanoEras StandardCrypto BatchCompatibleCrypto)` works fine * `show`ing a `OneEraHeader (CardanoEras ...)` yields the annoying error message about not being able to handle 2 different cryptos Using forAllBlind in the property removes the QC requirement to be able to `Show` the generated values which makes it work.
Co-authored-by: Sebastien Guillemot <[email protected]>
5018: Use ouroboros-network-0.3.0.2 and ouroboros-network-framework-0.2.0.1 r=dermetfan a=coot Co-authored-by: Marcin Szamotulski <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>
Waiting for a day, at a pace of one block every 20 seconds would generate 4320 blocks which takes forever to be created and processes, even in IO sim. We don't really observe the issue now because we cheat in the way we generate the block. This commit helps preparing for a more realistic block generation.