Home / Input Output / cardano-node
Oct 13, 7-8 PM (6)
Oct 13, 8-9 PM (0)
Oct 13, 9-10 PM (5)
Oct 13, 10-11 PM (1)
Oct 13, 11-12 AM (2)
Oct 14, 12-1 AM (1)
Oct 14, 1-2 AM (0)
Oct 14, 2-3 AM (2)
Oct 14, 3-4 AM (3)
Oct 14, 4-5 AM (1)
Oct 14, 5-6 AM (0)
Oct 14, 6-7 AM (4)
Oct 14, 7-8 AM (4)
Oct 14, 8-9 AM (5)
Oct 14, 9-10 AM (2)
Oct 14, 10-11 AM (3)
Oct 14, 11-12 PM (4)
Oct 14, 12-1 PM (1)
Oct 14, 1-2 PM (1)
Oct 14, 2-3 PM (4)
Oct 14, 3-4 PM (0)
Oct 14, 4-5 PM (1)
Oct 14, 5-6 PM (1)
Oct 14, 6-7 PM (2)
Oct 14, 7-8 PM (1)
Oct 14, 8-9 PM (0)
Oct 14, 9-10 PM (0)
Oct 14, 10-11 PM (0)
Oct 14, 11-12 AM (0)
Oct 15, 12-1 AM (0)
Oct 15, 1-2 AM (0)
Oct 15, 2-3 AM (0)
Oct 15, 3-4 AM (2)
Oct 15, 4-5 AM (0)
Oct 15, 5-6 AM (0)
Oct 15, 6-7 AM (0)
Oct 15, 7-8 AM (1)
Oct 15, 8-9 AM (0)
Oct 15, 9-10 AM (2)
Oct 15, 10-11 AM (2)
Oct 15, 11-12 PM (5)
Oct 15, 12-1 PM (1)
Oct 15, 1-2 PM (2)
Oct 15, 2-3 PM (1)
Oct 15, 3-4 PM (5)
Oct 15, 4-5 PM (4)
Oct 15, 5-6 PM (0)
Oct 15, 6-7 PM (0)
Oct 15, 7-8 PM (0)
Oct 15, 8-9 PM (0)
Oct 15, 9-10 PM (0)
Oct 15, 10-11 PM (4)
Oct 15, 11-12 AM (2)
Oct 16, 12-1 AM (1)
Oct 16, 1-2 AM (0)
Oct 16, 2-3 AM (9)
Oct 16, 3-4 AM (2)
Oct 16, 4-5 AM (5)
Oct 16, 5-6 AM (0)
Oct 16, 6-7 AM (0)
Oct 16, 7-8 AM (4)
Oct 16, 8-9 AM (0)
Oct 16, 9-10 AM (4)
Oct 16, 10-11 AM (1)
Oct 16, 11-12 PM (1)
Oct 16, 12-1 PM (1)
Oct 16, 1-2 PM (3)
Oct 16, 2-3 PM (3)
Oct 16, 3-4 PM (3)
Oct 16, 4-5 PM (0)
Oct 16, 5-6 PM (0)
Oct 16, 6-7 PM (0)
Oct 16, 7-8 PM (0)
Oct 16, 8-9 PM (0)
Oct 16, 9-10 PM (2)
Oct 16, 10-11 PM (0)
Oct 16, 11-12 AM (0)
Oct 17, 12-1 AM (0)
Oct 17, 1-2 AM (0)
Oct 17, 2-3 AM (0)
Oct 17, 3-4 AM (0)
Oct 17, 4-5 AM (0)
Oct 17, 5-6 AM (0)
Oct 17, 6-7 AM (1)
Oct 17, 7-8 AM (0)
Oct 17, 8-9 AM (0)
Oct 17, 9-10 AM (0)
Oct 17, 10-11 AM (0)
Oct 17, 11-12 PM (0)
Oct 17, 12-1 PM (0)
Oct 17, 1-2 PM (0)
Oct 17, 2-3 PM (0)
Oct 17, 3-4 PM (0)
Oct 17, 4-5 PM (0)
Oct 17, 5-6 PM (0)
Oct 17, 6-7 PM (0)
Oct 17, 7-8 PM (0)
Oct 17, 8-9 PM (0)
Oct 17, 9-10 PM (0)
Oct 17, 10-11 PM (0)
Oct 17, 11-12 AM (0)
Oct 18, 12-1 AM (0)
Oct 18, 1-2 AM (0)
Oct 18, 2-3 AM (0)
Oct 18, 3-4 AM (0)
Oct 18, 4-5 AM (0)
Oct 18, 5-6 AM (0)
Oct 18, 6-7 AM (0)
Oct 18, 7-8 AM (0)
Oct 18, 8-9 AM (0)
Oct 18, 9-10 AM (0)
Oct 18, 10-11 AM (0)
Oct 18, 11-12 PM (0)
Oct 18, 12-1 PM (2)
Oct 18, 1-2 PM (0)
Oct 18, 2-3 PM (0)
Oct 18, 3-4 PM (0)
Oct 18, 4-5 PM (0)
Oct 18, 5-6 PM (0)
Oct 18, 6-7 PM (0)
Oct 18, 7-8 PM (0)
Oct 18, 8-9 PM (0)
Oct 18, 9-10 PM (0)
Oct 18, 10-11 PM (0)
Oct 18, 11-12 AM (0)
Oct 19, 12-1 AM (0)
Oct 19, 1-2 AM (0)
Oct 19, 2-3 AM (0)
Oct 19, 3-4 AM (0)
Oct 19, 4-5 AM (1)
Oct 19, 5-6 AM (9)
Oct 19, 6-7 AM (2)
Oct 19, 7-8 AM (0)
Oct 19, 8-9 AM (0)
Oct 19, 9-10 AM (0)
Oct 19, 10-11 AM (1)
Oct 19, 11-12 PM (7)
Oct 19, 12-1 PM (5)
Oct 19, 1-2 PM (1)
Oct 19, 2-3 PM (25)
Oct 19, 3-4 PM (0)
Oct 19, 4-5 PM (1)
Oct 19, 5-6 PM (0)
Oct 19, 6-7 PM (2)
Oct 19, 7-8 PM (3)
Oct 19, 8-9 PM (0)
Oct 19, 9-10 PM (0)
Oct 19, 10-11 PM (1)
Oct 19, 11-12 AM (0)
Oct 20, 12-1 AM (0)
Oct 20, 1-2 AM (0)
Oct 20, 2-3 AM (0)
Oct 20, 3-4 AM (1)
Oct 20, 4-5 AM (0)
Oct 20, 5-6 AM (1)
Oct 20, 6-7 AM (1)
Oct 20, 7-8 AM (0)
Oct 20, 8-9 AM (1)
Oct 20, 9-10 AM (0)
Oct 20, 10-11 AM (3)
Oct 20, 11-12 PM (0)
Oct 20, 12-1 PM (1)
Oct 20, 1-2 PM (2)
Oct 20, 2-3 PM (3)
Oct 20, 3-4 PM (0)
Oct 20, 4-5 PM (0)
Oct 20, 5-6 PM (0)
Oct 20, 6-7 PM (3)
Oct 20, 7-8 PM (0)
196 commits this week Oct 13, 2020 - Oct 20, 2020
Fix default ipv4 & ipv6 address logic
The bug was a result of a misuse of `Data.List.span` applied to a list
of addresses return by `getAddrInfo`.  If the system returned `AF_INET`
addresses first it worked fine, but if it returned `AF_INET6` address
first, the ipv4 address was left undefined.   `Data.List.partition` is
the right function to use or just a `find` like in this patch.
Move warnings from cabal.project to the .cabal files
The warning flags for the local packages are listed in the separate `.cabal`
files as well as in `cabal.project`. I believe the advantage of having them in
`cabal.project` is that they can easily be changed all at once.

However, this has some annoying downsides: the flags are now in *two places*,
and as with any duplication, it got out of sync. Some flags were in one place
but not in the other and vice versa. Some components were missing the flags,
etc.

Moreover, this can be confusing, as changing the flags in a `.cabal` file
doesn't always have the effect you expect because the flags in the
`cabal.project` override them.

For example: GHC 8.10 is better at detecting redundant pattern matches, so I
removed the now redundant matches. But to keep the build warning-free with GHC
8.6.5 (although that is not a hard requirement), we can disable these warnings
for GHC < 8.10. Unfortunately, putting this logic in the `.cabal` file doesn't
work, since it's overridden by the flag in the `cabal.project` file. Putting the
logic in both files would be wrong. (I know that we can just leave the warning
enabled for GHC 8.6.5, but that's not the point. Avoiding the duplication and
confusion is.)

Solution: enable all the desired warnings flags in the `.cabal` files, remove
them from the `cabal.project` file, except for the `-Werror` flags so that these
can be quickly removed when desired.

Tip: if you want to allow warnings in some module during development, add the
following line to the top of the module:

    {-# OPTIONS_GHC -Wwarn #-}