Merge pull request #5147 from IntersectMBO/mwojtowicz/mux-ingressq-strict-pair
Use strict pairs in network-mux IngressQueue
Use strict pairs in network-mux IngressQueue
A trace is emitted whenever a hot outbound peer is demoted or closed (possibly due to an error), giving the duration in seconds of how long the peer has been in hot mode. Some other refactoring to aid comprehensibility
Traces durations upon receiving sigusr1 interrupt.
The property is only satisfied if there are no transaction which advertise wrong size.
* removed `numTxIdsToRequest` (not used & wrong) * replaced repeated code with a new function `splitAcknowledgedTxIds` * added test for `splitAcknowledgedTxIds`
Pass requested txids with sizes to the `collectTxs` call.
* send `getTxAdvSize` rather than `getTxSize` together with `getTxId`; * fixed properties in presence of wrongly sized txs, the conditions are much weeker; hance * generate much less wrongly sized txs.
All other fields are strict.
* Fixed Show instance for TestAddress: Deriving via Quiet produces a string which is not syntactivly valid Haskell * Show instance for `NodeArgs`: added brackes where needed. * Imports which work when pasting examples (still some imports need to be added). Using `-Wno-unused-imports` though.
When there's nothing to acknowledge, we return `TxsToMempool`, thus we also should update the `toMempoolTxs` field.
When we are acknowledging txs we also choose tx-s to be submitted to the mempool. We shouldn't disregard all acknowledged tx-s when we find a first buffered one, instead we can ignore them since they were already successfully submitted to the mempool.