Home / Reports / May 4, 2023
Thursday, May 4, 2023
75 commits had been pushed across 22 repos by 31 authors. There were 1,426,543 additions and 241,217 deletions. Official weekly status updates can be found on essentialcardano.io.
Authors
![iohk-bors[bot]](https://avatars.githubusercontent.com/in/17473?v=4&s=80)
Repos Updated
- plutus15
- cardano-token-registry10
- cardano-wallet10
- uptime9
- hedgehog-extras6
- formal-ledger-specifications3
- cardano2
- cardano-node-tests2
- catalyst-core2
- engineering2
- haskell.nix2
- cardano-transaction-lib2
- yoroi1
- cardano-base1
- cardano-documentation1
- cardano-updates1
- hydra1
- iohk-nix1
- marlowe-explorer1
- mithril1
- plutus-apps1
- plutus-ops1
Commit Log
05:58:12
[0cd2c104]
docs: Merge #3893 3893: refactor: extract calculateMinimumFee r=Unisay a=Unisay <!--
Detail in a few bullet points the work accomplished in this PR.
Before you submit, don't forget to:
CODE-OF-CONDUCT.md LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Make sure the GitHub PR fields are correct:
✓ Set a good Title for your PR.
✓ Assign yourself to the PR.
✓ Assign one or more reviewer(s).
✓ Link to a Jira issue, and/or other GitHub issues or PRs.
✓ In the PR description delete any empty sections
and all text commented in <!--, so that this text does not appear
in merge commit messages.
CODE-OF-CONDUCT.md LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Don't waste reviewers' time:
✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped through.
CODE-OF-CONDUCT.md LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Try to make your intent clear:
✓ Write a good Description that explains what this PR is meant to do.
✓ Jira will detect and link to this PR once created, but you can also
link this PR in the description of the corresponding Jira ticket.
✓ Highlight what Testing you have done.
✓ Acknowledge any changes required to the Documentation.
-->
- [x] I have extracted `calcMinCost` from `TxLayer` into a standalone function `calculateMinimumFee`
- [x] Refactored functions that required a whole `TxLayer` to depend on the `TxWitnessTag` only.
### Issue Number
ADP-2967 Co-authored-by: Yura Lazarev <[email protected]> Source commit: afbadec58196975097b89b8e96231702da089d7a
(cardano-wallet)
06:19:16
[f1f351ae]
Merge pull request #2865 from cardano-tools-nft/18ce003a-d7b9-49af-95fe-7157c81c7ba6
(cardano-token-registry)
08:34:47
[c59999ce]
Merge pull request #1492 from Plutonomicon/klntsky/add-docs-on-query-layers
(cardano-transaction-lib)
09:54:57
[9e3d8c6f]
Merge pull request #484 from input-output-hk/filip/feat/cardano-ecosystem-tools-external
(cardano-documentation)
10:24:38
[d6060372]
docs: Merge #3902 3902: [ADP-3008] Remove `removePendingOrExpiredTx` from `DBLayer` r=HeinrichApfelmus a=HeinrichApfelmus ### Overview
We want to remove functions from the `DBLayer` record until essentially all DB access is done through the `walletsDB :: DBVar`.
This pull request removes `removePendingOrExpiredTx` from the `DBLayer` record.
### Issue number
ADP-3008 Co-authored-by: Heinrich Apfelmus <[email protected]> Source commit: fe892655177cefb632930b87f307847d4ef9b1fb
(cardano-wallet)
11:00:12
[75ca5b63]
Deploying to gh-pages from @ input-output-hk/plutus@2ef7feaff6c2721dcda1a8ec1d7ee60613095d92 🚀
(plutus)
11:12:26
[e56cde92]
add Plutus Benchmarks (customSmallerIsBetter) benchmark result for 2ef7feaff6c2721dcda1a8ec1d7ee60613095d92
(plutus)
11:27:28
[19977951]
Deploying to gh-pages from @ input-output-hk/plutus@6a9cf6ddca66931bece8446e2fefb35afc7eedb7 🚀
(plutus)
12:00:00
[1000f15b]
Deploying to gh-pages from @ input-output-hk/engineering@9fb594ee01dcae2a294f291ea110bcd5a477e9e2 🚀
(engineering)
12:10:09
[1ba903c3]
add Plutus Benchmarks (customSmallerIsBetter) benchmark result for 6a9cf6ddca66931bece8446e2fefb35afc7eedb7
(plutus)
12:10:47
[1728a44d]
docs: Merge #3904 #3905 3904: Fix the restoration benchmark. r=jonathanknowles a=jonathanknowles ## Issue
ADP-3011
## Summary
This PR attempts to fix the `estimate tx fee` section of the restoration benchmark.
## Details
The `estimate tx fee` section of the restoration benchmark is currently failing with errors similar to:
```hs
ExceptionSelectAssets
(ErrSelectAssetsSelectionError
(SelectionOutputErrorOf
(SelectionOutputError
{ outputIndex = 0
, outputErrorInfo =
SelectionOutputCoinInsufficient
(SelectionOutputCoinInsufficientError
{ minimumExpectedCoin = Coin 995610
, output =
( Address ".."
, TokenBundle {coin = Coin 1, tokens = TokenMap (fromList [])}
)
}
)
})))
```
This error occurs when a user-specified output has a lovelace quantity that is greater than zero, but lower than the minimum value that would be acceptable to the ledger. In this case, `balanceTx` will refuse to balance the transaction, returning an error similar to the one above. (Note that `1` lovelace is lower than `995610` lovelace, which is the minimum accceptable amount of lovelace for this particular output.)
This PR changes the user-specified output to have a lovelace quantity of zero. If an output has a lovelace quantity of zero, then `balanceTx` (which is called by `transactionFee`) should automatically assign a minimal quantity of lovelace to that output before balancing the transaction and computing the fee. 3905: Actually use a fixed seed in `UTxOIndexBench`. r=jonathanknowles a=jonathanknowles ## Issue Number
ADP-2975
## Summary
This PR fixes the generation of UTxO maps in `UTxOIndexBench`.
The previous method of generation assumed that it was possible to use the `QC.variant` function to generate values according to a fixed seed, but that assumption was flawed. This flaw would result in the benchmark generating different UTxO maps on every run, which could cause unwanted variance in the benchmark timings.
This PR:
- adds a new function `generateWith` to `Test.QuickCheck.Extra`.
- uses the `generateWith` function to repair the generation logic in `UTxOIndexBench`. Co-authored-by: Jonathan Knowles <[email protected]> Source commit: 15cfcd0fe0674f41b181e57785108f398df7d3b9
(cardano-wallet)
12:32:35
[8c2eff1e]
plutusStaging: Bump plutus to 18175ec24482032b826962bd81da527e69c2abe7
(plutus-ops)
12:44:35
[2a09d4a6]
Deploying to gh-pages from @ input-output-hk/plutus-apps@18175ec24482032b826962bd81da527e69c2abe7 🚀
(plutus-apps)
13:28:53
[16cd9581]
Merge pull request #1773 from saratomaz/run_governance_commands_only_alonzo
(cardano-node-tests)
13:37:29
[4b2766ef]
Merge pull request #1768 from saratomaz/check_reference_inputs
(cardano-node-tests)
14:04:56
[eb2350ce]
Add extra assertion functions, fix readM to show correct line. Version 0.4.4. (#33)
(hedgehog-extras)
14:32:26
[5125f7fa]
docs: Merge #3903 3903: [ADP-3010] Remove `readLocalTxSubmissionPending` from `DBLayer` r=HeinrichApfelmus a=HeinrichApfelmus ### Overview
We want to remove functions from the `DBLayer` record until essentially all DB access is done through the `walletsDB :: DBVar` .
This task is about removing `readLocalTxSubmissionPending` from the `DBLayer` record.
As this function is tested in a unit test in `WalletSpec`, we add it to `Cardano.Wallet` instead.
### Issue number
ADP-3010 Co-authored-by: Heinrich Apfelmus <[email protected]> Source commit: cf934d92396388ba778f7935f67a0d7ab9a9c280
(cardano-wallet)
14:55:38
[c7b13622]
Deploying to gh-pages from @ input-output-hk/plutus@223419675377c3dde2e0dcbb169f6672891ceba0 🚀
(plutus)
15:47:12
[77a887af]
add Plutus Benchmarks (customSmallerIsBetter) benchmark result for 223419675377c3dde2e0dcbb169f6672891ceba0
(plutus)
17:56:36
[943b3c4f]
Update fb0e9a083ac66c814548002cbdfc54557e064e4cdf5c6675e72d22b44445414e.json
(cardano-token-registry)
18:17:03
[a9288162]
Deploying to gh-pages from @ input-output-hk/plutus@a314571379d7ff51c793c2e1f7792bbb45ff9270 🚀
(plutus)
18:20:46
[f5490749]
Merge pull request #2873 from cardano-tools-nft/48cc08bb-5748-4572-9519-779e2b09af79
(cardano-token-registry)
18:21:58
[de00c781]
Merge pull request #2871 from cardano-tools-nft/be9a4d80-8416-4bba-989c-4fd6df81897e
(cardano-token-registry)
18:34:54
[c0a24dc0]
Deploying to gh-pages from @ input-output-hk/plutus@d1e244ec39c5247cb57da752fc22561e221557a6 🚀
(plutus)
19:09:09
[f24a7232]
add Plutus Benchmarks (customSmallerIsBetter) benchmark result for a314571379d7ff51c793c2e1f7792bbb45ff9270
(plutus)
20:06:49
[4303147d]
add Plutus Benchmarks (customSmallerIsBetter) benchmark result for d1e244ec39c5247cb57da752fc22561e221557a6
(plutus)
23:05:31
[3c5b081f]
🟩 C1 Devnet Sidechain Explorer is up (200 in 99 ms) [skip ci] [upptime]
(uptime)
23:05:32
[464f5fa6]
🟩 C1 Mainnet Sidechain Explorer is up (200 in 129 ms) [skip ci] [upptime]
(uptime)
23:35:50
[8dbdb68d]
PLT-5841 - Use paginated queries for fetching transactions from Runtime (#44)
(marlowe-explorer)