Home / Reports / May 17, 2023
Wednesday, May 17, 2023
93 commits had been pushed across 23 repos by 27 authors. There were 4,666,246 additions and 1,745,872 deletions. Official weekly status updates can be found on essentialcardano.io.
Authors
![iohk-bors[bot]](https://avatars.githubusercontent.com/in/17473?v=4&s=80)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?v=4&s=80)
Repos Updated
- cardano-db-sync20
- catalyst-core19
- uptime9
- cardano-wallet8
- cardano-token-registry5
- hydra-poc5
- marlowe5
- cardano-node-tests3
- blockfrost-utils2
- openapi2
- catalyst-som2
- hydra2
- blockfrost-backend-ryo1
- developer-portal1
- milkomeda-documentation1
- yoroi-frontend1
- cardano-crypto1
- cardano-updates1
- cardano-world1
- daedalus1
- haskell.nix1
- mithril1
- stackage.nix1
Commit Log
06:31:27
[113ddfc2]
Merge pull request #107 from blockfrost/esbuild-darwin-x86
(blockfrost-backend-ryo)
09:40:07
[82b60a96]
Merge pull request #870 from input-output-hk/always-push-docker-images
(hydra-poc)
10:16:08
[5f62b05a]
Merge pull request #3041 from cardano-foundation/deletion/3035
(cardano-token-registry)
10:30:11
[c08e7003]
docs: Merge #3928 3928: Tweak generators for 8x speedup of balanceTx property r=Anviking a=Anviking - [x] Rely less on CardanoApi in prop_balanceTransactionValid
- [x] Generate fewer PParam updates in tests
- [x] Use cheaper PParam gen for the sake of hashing
### Comments
`cabal test cardano-wallet:unit --test-options='-j 8 --match "valid transactions or fails"'`
#### This PR
```
Cardano.Wallet.Shelley.Transaction
balanceTransaction
produces valid transactions or fails [✔] (11278ms)
+++ OK, passed 1000 tests:
100.0% has payment outputs
55.0% >5 payment outputs
33.8% >10 payment outputs
9.6% >20 payment outputs
9.1% partial tx had zero ada outputs
49.1% existing total collateral
26.1% existing collateral return outputs
10.1% output below minCoinValue
5.6% missing tokens
3.9% conflicting networks
3.1% success
0.7% missing coin
0.5% existing collateral
0.4% maxTxSize limit exceeded
0.3% missing coin and tokens
0.1% ReferenceScriptsNotSupported
0.1% failed with ByronTxOutInContext
Finished in 11.2793 seconds, used 12.2644 seconds of CPU time
1 example, 0 failures
```
#### Master (376280e420)
```
Cardano.Wallet.Shelley.Transaction
balanceTransaction
produces valid transactions or fails [✔] (77431ms)
+++ OK, passed 1000 tests:
100.0% has payment outputs
55.8% >5 payment outputs
35.3% >10 payment outputs
10.1% partial tx had zero ada outputs
9.3% >20 payment outputs
50.9% existing total collateral
24.9% existing collateral return outputs
10.8% output below minCoinValue
4.7% missing tokens
4.0% conflicting networks
2.7% success
1.0% missing coin
0.5% missing coin and tokens
0.2% existing collateral
0.1% failed with ByronTxOutInContext
0.1% maxTxSize limit exceeded
0.1% unable to construct change
Finished in 77.4322 seconds, used 84.2236 seconds of CPU time
1 example, 0 failures
```
### Issue Number
<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
Note: Jira issues of the form ADP- will be auto-linked. -->
Co-authored-by: Johannes Lund <[email protected]> Source commit: dfaafe93b461fa9f2f582b7a652625c7baef8a5e
(cardano-wallet)
11:04:23
[357e6878]
docs: Merge #3940 #3941 3940: Simplify treatment of extra input and output value within `balanceTx`. r=Anviking a=jonathanknowles ## Issue
None. Spotted an opportunity for simplification while reviewing PRs.
## Summary
In this PR, we:
- Coalesce four "extra value" fields of `SelectionParams` to just a pair of fields: `extraValue{In,Out}`. These fields are used to adjust the coin selection algorithm's notion of extra value on the input and output sides of a transaction.
- Before this PR, the `{ada,tokens}InOutputs` values were computed separately and passed separately.
- With this PR, the value of the outputs can be computed with a single traversal.
- Move definitions of extra input and output value closer to their usage sites.
## Potential Future Work
In the future, we can consider pushing this simplification further into the coin selection algorithm. But that's probably best left for another day, in order to keep this PR simple. 3941: Simplify `posAndNegFromCardanoValue`. r=Anviking a=jonathanknowles ## Issue
None. Spotted while reviewing PRs.
## Summary
This PR reuses `fromCardanoValue` to simplify `posAndNegFromCardanoValue`.
The relevant property test still passes:
```
Cardano.Wallet.Shelley.Transaction
balanceTransaction
posAndNegFromCardanoValue
roundtrips with toCardanoValue [✔] (7ms)
+++ OK, passed 100 tests.
``` Co-authored-by: Jonathan Knowles <[email protected]> Source commit: b0de639c72c324328636d3fbe8e8bc597d86b75e
(cardano-wallet)
12:28:55
[835d6b1a]
docs: Merge #3931 3931: [ADP-3034] remove BoundedAddressLength class r=paolino a=paolino - [x] Add key flavors singletons
- [x] Switch `BoundedAddressLengthClass` to plain function over the singleton
ADP-3034 Co-authored-by: paolino <[email protected]> Source commit: ffb9c313433d04349d220f61942e7a4fe863ccb0
(cardano-wallet)
12:34:38
[86f0d1d9]
Merge pull request #3121 from input-output-hk/chore/ddw-1203-currency-proxy
(daedalus)
13:25:21
[788ceea7]
Fix accounting for genesis blocks when rolling back to genesis
(cardano-db-sync)
13:25:21
[c4890f5c]
Fix nix setup; we were lacking conway data, also iohk-nix is supposed to become the authorative env repo again.
(cardano-db-sync)
13:25:21
[3916c25e]
remove temporary iohkNix branch reference, bump iohkNix and haskellNix
(cardano-db-sync)
13:40:39
[4d56248d]
docs: Merge #3943 3943: Also fix restoration bench in seq case r=Anviking a=Anviking Extend restore bench fix for seq case
The previous fix (#3904 ) applied only to rnd, so let's fix it for seq as well, and hopefully all should be well now.
### Issue
ADP-3011 Co-authored-by: Johannes Lund <[email protected]> Source commit: 413cac659223497440653e6a6d92dace1732f829
(cardano-wallet)
14:28:27
[f7ff1771]
Merge pull request #1816 from input-output-hk/check_gh_issues
(cardano-node-tests)
15:58:02
[c77d536d]
Merge pull request #877 from input-output-hk/use-cardano-scaling-cachix
(hydra-poc)
21:50:16
[50df793b]
Merge pull request #1819 from input-output-hk/fix_property_vs_method
(cardano-node-tests)
23:05:23
[9cdf4c00]
🟩 C1 Devnet Sidechain Explorer is up (200 in 274 ms) [skip ci] [upptime]
(uptime)
23:05:25
[9bd3d75f]
🟩 C1 Mainnet Sidechain Explorer is up (200 in 687 ms) [skip ci] [upptime]
(uptime)
23:34:26
[d95eb169]
Removed Draft Docs for NPG-6386-fix-ideascale-importer-ideascale-importer
(catalyst-core)