Home / Reports / Mar 28, 2023
Tuesday, March 28, 2023
57 commits had been pushed across 19 repos by 25 authors. There were 368,839 additions and 359,023 deletions. Official weekly status updates can be found on essentialcardano.io.
Authors
Repos Updated
- uptime11
- catalyst-core10
- cardano-ledger-specs4
- haskell.nix4
- Developer-Experience-working-group3
- plutus3
- plutus-ops3
- cardano-transaction-lib3
- cardano-js-sdk2
- cardano-node2
- cardano-wallet2
- formal-ledger-specifications2
- ouroboros-network2
- hydra-voting-poc1
- cardano-clusterlib-py1
- dapps-certification1
- metadata-registry-testnet1
- ouroboros-consensus1
- stackage.nix1
Commit Log
00:28:06
[cbbf9dbc]
add Mempool (customSmallerIsBetter) benchmark result for 5e04afe2e6dcaeefac39f118c7d92afa848fec78
(ouroboros-consensus)
01:29:00
[c0d15303]
docs: Merge #3801 3801: Strengthen property tests for `applyBlocks`. r=jonathanknowles a=jonathanknowles ## Issue
ADP-2840 / #3785
## Summary
The `applyBlocks` function was recently changed so that fees of incoming transactions, if present (i.e., not `Nothing`), are no longer stripped away (i.e., no longer replaced with `Nothing`).
The following commits are relevant:
- https://github.com/input-output-hk/cardano-wallet/commit/120c7decdc662607758de60c7c8690845baeb22b
- https://github.com/input-output-hk/cardano-wallet/commit/634265eb4bb13bc0c7782c889753affce62e1760
Consequently, it is now more straightforward to test our expectations about the `fee` field within our property tests for `applyBlocks`. In particular, we now test that `applyBlocks` does not modify the `fee` field in any way (if it is not `Nothing`), whereas before, the `fee` field was deliberately excluded from the test.
Note that this does rely on the fact that our transaction sequence generator never generates transactions with fees that are `Nothing`:
https://github.com/input-output-hk/cardano-wallet/blob/4af4c184a2f986a51c44c0f93a5eef7e7fa31acf/lib/wallet/src/Cardano/Wallet/Primitive/Types/Tx/TxSeq/Gen.hs#L319-L320
If in future we revise this generator to also cover transactions where fees can be `Nothing`, we will have to also revise these property tests.
This PR adjusts the following property tests, which test that `applyBlocks` returns all transactions that are relevant to the wallet (and no others), and that they are returned in the same order that they appear in the blockchain:
- [`prop_applyBlocks_filteredTxs_someOurs`](https://github.com/input-output-hk/cardano-wallet/blob/76f09ef7fda58418710b8394603d75d677b34425/lib/wallet/test/unit/Cardano/Wallet/Primitive/ModelSpec.hs#L2657)
tests `applyBlocks` in scenarios where **_only some_** transactions in an arbitrary block sequence are relevant to a wallet.
- [`prop_applyBlocks_filteredTxs_allOurs`](https://github.com/input-output-hk/cardano-wallet/blob/76f09ef7fda58418710b8394603d75d677b34425/lib/wallet/test/unit/Cardano/Wallet/Primitive/ModelSpec.hs#L2687)
tests `applyBlocks` in scenarios where **_all_** transactions in an arbitrary block sequence are relevant to a wallet. Co-authored-by: Jonathan Knowles <[email protected]> Source commit: 378d4b524b0690df1e9e31944e4561a46d3d80ad
(cardano-wallet)
02:18:18
[919ef570]
Merge pull request #3360 from input-output-hk/lehins/truncate-ptrs-upon-translation
(cardano-ledger-specs)
02:22:12
[4da673f2]
add Haskell Benchmark (customSmallerIsBetter) benchmark result for 919ef57005d47b1512be6e0d36e42c1fdaf1b6ec
(cardano-ledger-specs)
06:13:18
[f72be532]
Merge pull request #668 from input-output-hk/fix/circular-deps-check
(cardano-js-sdk)
06:57:18
[80113f97]
Merge pull request #672 from input-output-hk/fix/transaction-resubmitted-too-soon
(cardano-js-sdk)
10:46:46
[dcb56241]
Merge pull request #1462 from Plutonomicon/klntsky/1419-reward-redeemer-indexing
(cardano-transaction-lib)
10:49:23
[4cfbb6d0]
Deploying to gh-pages from @ Plutonomicon/cardano-transaction-lib@dcb56241983f3e53a2783a9ff26f25290d5519a5 🚀
(cardano-transaction-lib)
11:30:28
[c4d9957d]
Use automated deriving for DecEq of address types (#81)
(formal-ledger-specifications)
12:39:55
[a0bf8662]
Merge pull request #172 from input-output-hk/wait_for_block_no
(cardano-clusterlib-py)
13:57:06
[c672474e]
staging: Bump marlowePlay to 747ae6e4e488668f081414621c29c2886b1b525a
(plutus-ops)
14:20:32
[96c7bcf6]
Removed Draft Docs for NPG-5730-python-idea-scale-data-import-should-upsert-data
(catalyst-core)
15:44:22
[a9f1a051]
Deploying to gh-pages from @ input-output-hk/plutus@6f3f472138dd9394a4b9950ace13921b53f1111e 🚀
(plutus)
16:49:50
[3b430cfd]
add Plutus Benchmarks (customSmallerIsBetter) benchmark result for 6f3f472138dd9394a4b9950ace13921b53f1111e
(plutus)
18:03:56
[8e14f99b]
Merge pull request #60 from Benjmhart/minutes/2023-03-28
(Developer-Experience-working-group)
18:28:47
[405c7558]
plutusStaging: Bump plutus to 835a7ed6d5b6313351c30dae29309e4ca5059a90
(plutus-ops)
18:57:17
[db4126e8]
plutusStaging: Bump plutus to 2b71ee10f7eacc927ccc6af51640af761f413c3f
(plutus-ops)
21:17:08
[b6faed1d]
add Haskell Benchmark (customSmallerIsBetter) benchmark result for ec86caf6cd2ff3ac88f1fef9e425406b269209b3
(cardano-ledger-specs)
23:05:41
[cf2da748]
🟩 C1 Devnet Sidechain Explorer is up (200 in 143 ms) [skip ci] [upptime]
(uptime)
23:05:42
[4eba6479]
🟩 C1 Mainnet Sidechain Explorer is up (200 in 596 ms) [skip ci] [upptime]
(uptime)