Home / Reports / Nov 22, 2022
Tuesday, November 22, 2022
61 commits had been pushed across 12 repos by 19 authors. There were 94,699 additions and 56,450 deletions. Official weekly status updates can be found on essentialcardano.io.
Authors
![iohk-bors[bot]](https://avatars.githubusercontent.com/in/17473?v=4&s=80)
Repos Updated
- cardano-wallet31
- cardano-documentation7
- openapi4
- catalyst-core4
- ouroboros-network4
- haskell.nix3
- blockfrost-rust2
- yoroi-mobile2
- cardano-node-tests1
- cardano-world1
- koi-pond1
- mithril1
Commit Log
02:58:16
[4105b3cc]
docs: Merge #3596 3596: Remove `scrypt` flag from libraries where it's unneeded. r=jonathanknowles a=jonathanknowles ## Issue Number
ADP-2386 (follow on from #3591)
## Summary
This PR removes the `scrypt` flag from the following libraries:
- `cardano-wallet-primitive`
- `cardano-wallet-coin-selection` Co-authored-by: Jonathan Knowles <[email protected]> Source commit: 144db95fba9ec723a2f828bbfb24bd85c0c1d0e1
(cardano-wallet)
09:56:55
[e4a0aaa9]
Merge pull request #1500 from input-output-hk/refactor_tx_tests
(cardano-node-tests)
10:36:12
[40519eb4]
docs: Merge #3595 3595: Temporarily disable `prop_outputsSatisfyMinAdaRequirement` r=Anviking a=Anviking - [x] Temporarily disable failing `prop_outputsSatisfyMinAdaRequirement`
### Comments
- It is [failing](https://github.com/input-output-hk/cardano-wallet/pull/3591#issuecomment-1319932086) due to too-loose validation of user-specified outputs containing datum hashes.
- The validation logic should take the full `WriteTx.TxOut` / `Ledger.TxOut` into account.
Was also thinking about just adding something like this to balanceTx:
```haskell
guardTxOutMinAda (Cardano.Tx (Cardano.ShelleyTxBody _ body _ _ _ _) _) =
let outs = WriteTx.outputs (WriteTx.recentEra `@era)` body
in mapM_ guardOut $ zip [0..] outs
where
guardOut
:: (Int, WriteTx.TxOut (WriteTx.ShelleyLedgerEra era))
-> ExceptT ErrBalanceTx m (Cardano.Tx era)
guardOut (ix, out) =
-- when not enough:
throwE
$ ErrBalanceTxSelectAssets
$ ErrSelectAssetsSelectionError
$ SelectionOutputErrorOf
$ SelectionOutputCoinInsufficient
$ SelectionOutputCoinInsufficientError
{ minimumExpectedCoin = error "todo"
, output = toWalletOutput out
}
```
but doing nothing for now at least.
### Issue Number
ADP-2347
Co-authored-by: Johannes Lund <[email protected]> Source commit: 0099065e23dc1e0987fa47fbe4f24e100cf355b0
(cardano-wallet)
14:15:10
[53b4e40c]
Merge pull request #434 from input-output-hk/olgahryniuk-patch-44
(cardano-documentation)
14:43:03
[dbeb6b30]
Merge pull request #435 from input-output-hk/olgahryniuk-patch-45
(cardano-documentation)
18:36:22
[3ec62569]
Merge pull request #3597 from input-output-hk/piotr/e2e-test-windows
(cardano-wallet)
18:43:22
[e1c61d31]
docs: Merge pull request #3597 from input-output-hk/piotr/e2e-test-windows e2e tests fix windows config Source commit: 3ec62569078b4e26b459a32b31808acc240da86b
(cardano-wallet)
22:25:39
[5903000d]
docs: Merge #3577 3577: Get/list shared txs r=Anviking a=paweljakubas <!--
Detail in a few bullet points the work accomplished in this PR.
Before you submit, don't forget to:
LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes release.nix reports scripts shell.nix specifications test touch.me.CI weeder.dhall Make sure the GitHub PR fields are correct:
✓ Set a good Title for your PR.
✓ Assign yourself to the PR.
✓ Assign one or more reviewer(s).
✓ Link to a Jira issue, and/or other GitHub issues or PRs.
✓ In the PR description delete any empty sections
and all text commented in <!--, so that this text does not appear
in merge commit messages.
LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes release.nix reports scripts shell.nix specifications test touch.me.CI weeder.dhall Don't waste reviewers' time:
✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped through.
LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes release.nix reports scripts shell.nix specifications test touch.me.CI weeder.dhall Try to make your intent clear:
✓ Write a good Description that explains what this PR is meant to do.
✓ Jira will detect and link to this PR once created, but you can also
link this PR in the description of the corresponding Jira ticket.
✓ Highlight what Testing you have done.
✓ Acknowledge any changes required to the Documentation.
-->
- [x] Updated get/list shared tx in swagger
- [x] Adding plumbing in api scaffolding layer, link, reusing between shelley and shared modes
- [x] adding integration tests
### Comments
<!-- Additional comments, links, or screenshots to attach, if any. -->
### Issue Number
adp-2224
<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
Note: Jira issues of the form ADP- will be auto-linked. -->
Co-authored-by: Pawel Jakubas <[email protected]> Source commit: 999e7e15c9cf04133b6ae8593e1dcaca1d1c31d2
(cardano-wallet)